Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to include documentation on queryBuilding data #177

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

m-goggins
Copy link
Collaborator

@m-goggins m-goggins commented Nov 25, 2024

PULL REQUEST

Summary

This PR adds documentation about the source(s) of the data in the db, including the eRSD, VSAC, and HLN curated conditions<>category mapping.

Related Issue

Fixes #176

Additional Information

I added a bit more information on the eRSD and VSAC here. It may be more informational for our team and may not be necessary to include in public facing documentation.

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers
  • Update documentation

@m-goggins m-goggins marked this pull request as ready for review November 26, 2024 16:26
Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple suggestions I think improve the flow/clarity and address a few implied details, but nothing blocking here so I'm approving so you can approve at your leisure (if or when you decide whether to make the changes).

query-connector/README.md Outdated Show resolved Hide resolved
query-connector/README.md Outdated Show resolved Hide resolved
query-connector/README.md Outdated Show resolved Hide resolved
query-connector/README.md Outdated Show resolved Hide resolved
@m-goggins m-goggins merged commit 7844330 into main Nov 26, 2024
5 checks passed
@m-goggins m-goggins deleted the marcelle/update-documentation branch November 26, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update QC Data Documentation
2 participants